ext/wsgi: use current span when extracting fails #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If propagator.extract() returns INVALID_SPAN it means that the http headers do not contain valid trace information, in this case use the current span as parent. Before this change INVALID_SPAN was being passed to create_span then all the traces were generated with trace_id = 0x0.
mauriciovasquezbernal
requested review from
a-feld,
c24t,
carlosalberto,
lzchen,
Oberon00,
reyang and
toumorokoshi
as code owners
|
If trace-ID zero is used, that's a bug in the SDK. EDIT: Related: #228 (comment) |
|
fyi discussion ticket for how to handle invalid spans: #233 |
|
Closing in favor of #235 |
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
… (open-telemetry#232) * fix: enable async hooks manager in node tracer * fix(node-tracer): set scope manager as optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If propagator.extract() returns INVALID_SPAN it means that the http headers
do not contain valid trace information, in this case use the current span as
parent.
Before this change INVALID_SPAN was being passed to create_span then all the
traces were generated with trace_id = 0x0.